Decouple Slang shader compilation from the core runtime - #36
Merged
Merged
Conversation
Moved the <ItemGroup> including SGSR-LICENSE.txt for Release builds to after the <Import> statement. No functional changes; only element reordering.
Moved ZenithCompiler and dependencies from Zenith.NET to new Zenith.NET.Compiler project using Slangc.NET. Updated CornellBox.csproj and FluidTank.csproj to reference Zenith.NET.Compiler. Relocated Slangc.NET package reference. Restored ZenithCompiler implementation in the new project.
Changed reference from Zenith.NET to Zenith.NET.Compiler in Compile.cs to reflect the correct project dependency. No other code changes made.
Updated Slangc.NET NuGet package from 2026.16.1 to 2026.18.0 to use the latest features and fixes. No other package references were changed.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Update documentation and installation guidance to reflect the new compiler package.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Decouples Slang shader compilation from the core runtime by introducing the Zenith.NET.Compiler package.
Changes:
- Moves
ZenithCompilerandSlangc.NETout of the core package. - Updates shader-generation scripts and sample projects.
- Upgrades Slangc.NET to 2026.18.0 and refreshes shader bytecode.
File summaries
| File | Description |
|---|---|
Zenith.NET.slnx |
Adds the compiler project. |
sources/Zenith.NET/Zenith.NET.csproj |
Removes the compiler dependency from the runtime. |
sources/Zenith.NET.Compiler/ZenithCompiler.cs |
Provides the extracted compiler API. |
sources/Zenith.NET.Compiler/Zenith.NET.Compiler.csproj |
Defines the compiler package and dependencies. |
sources/Extensions/Zenith.NET.Extensions.Upscaling/Zenith.NET.Extensions.Upscaling.csproj |
Preserves shader asset packaging. |
sources/Extensions/Zenith.NET.Extensions.Upscaling/Shaders/Compile.cs |
Uses the compiler for shader generation. |
sources/Extensions/Zenith.NET.Extensions.ImGui/Shaders/Compile.cs |
Uses the compiler for shader generation. |
sources/Experiments/FluidTank/FluidTank.csproj |
References the compiler project. |
sources/Experiments/CornellBox/CornellBox.csproj |
References the compiler project. |
sources/Directory.Packages.props |
Upgrades Slangc.NET. |
Review details
- Files reviewed: 9/15 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
ZenithCompilerand Slangc.NET into theZenith.NET.Compilerproject/package.ZenithCompilerremains in theZenith.NETnamespace.Update consumers, upgrade Slangc.NET to 2026.18.0, and regenerate embedded shaders.
Closes #29