Add best-iterate restoration on numerical-error / max-iter exits - #76
Merged
Merged
Conversation
Track the iterate with the lowest composite residual metric (in inaccurate-tolerance units) during solve. On QOCO_NUMERICAL_ERROR or QOCO_MAX_ITER exit, restore that iterate; if it satisfies the inaccurate tolerance, downgrade the status to QOCO_SOLVED_INACCURATE. Rescues near-converged solves that hit a late-stage stall with a usable solution rather than failing outright. Cheap (no per-iter cost beyond a copy when a new best is found) and additive — strict SOLVED count is unchanged on all benchmarks; essentially-solved count goes up. Benchmarks (default settings, full sets): - misc/iter_0024: NUMERICAL_ERROR -> SOLVED_INACCURATE - mm/CVXQP1_L: NUMERICAL_ERROR -> SOLVED_INACCURATE - all other problems unchanged
Download Benchmark ArtifactsBenchmark SummaryProblems Solved
|
Download Benchmark ArtifactsBenchmark SummaryProblems Solved
|
Download Benchmark ArtifactsBenchmark SummaryProblems Solved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track the iterate with the lowest composite residual metric (in inaccurate-tolerance units) during solve. On QOCO_NUMERICAL_ERROR or QOCO_MAX_ITER exit, restore that iterate; if it satisfies the inaccurate tolerance, downgrade the status to QOCO_SOLVED_INACCURATE.
Rescues near-converged solves that hit a late-stage stall with a usable solution rather than failing outright. Cheap (no per-iter cost beyond a copy when a new best is found) and additive — strict SOLVED count is unchanged on all benchmarks; essentially-solved count goes up.
Benchmarks (default settings, full sets):