Skip to content

chore: fix README links, add LICENSE - #335

Open
Vlada-Q wants to merge 3 commits into
qonversion:mainfrom
Vlada-Q:marketing/hygiene-2026-09
Open

Vlada-Q wants to merge 3 commits into
qonversion:mainfrom
Vlada-Q:marketing/hygiene-2026-09

Conversation

@Vlada-Q

@Vlada-Q Vlada-Q commented Sep 22, 2026 •

Copy link
Copy Markdown

Two broken links, both from the shared README template.

  • [All other integrations here](qonversion.io/integrations) has no scheme. GitHub renders it as a repository-relative path, so on the rendered README it resolves to github.com/qonversion/unity-sdk/blob/main/qonversion.io/integrations and 404s. Now https://qonversion.io/integrations (200).
  • https://documentation.qonversion.io/discuss-new in Have a question? is left over from readme.io and returns 404 — it is not among the redirects the docs site keeps. That is the link a reader follows when something did not work. It now points at https://qonversion.io/contact-us (200), next to the existing GitHub issues link. The same target is used in the other SDK READMEs so the support channel is one and the same everywhere.

Typo. «paywals» → «paywalls» in the A/B test bullet (it is copied across the READMEs).

No licence text in the repository. The README ends with «Qonversion SDK is available under the MIT license» and carries an MIT badge, but there is no LICENSE file and the GitHub API reports license: null for this repository — so formally the licence exists only as a claim. For a team running a legal review before adopting an SDK, that is a stopper.

Added LICENSE with the MIT text copied from qonversion-ios-sdk, copyright holder unchanged (Qonversion team <hi@qonversion.io>). The badge now links to that file instead of the #license anchor inside the README.


Scope is deliberately narrow: links, licence, install, typo. Positioning, the opening paragraph, the bullets, the banner images and the version badge are untouched — those belong to the README template being rewritten separately.

Opened from a fork, so the review request could not be set from here — @SpertsyanKM, this one is for you.

🤖 Generated with Claude Code

Vlada-Q and others added 3 commits September 22, 2026 14:56
`[All other integrations here](qonversion.io/integrations)` has no scheme,
so GitHub renders it as a repository-relative path and it 404s where the
README is actually read. `https://documentation.qonversion.io/discuss-new`
is left over from readme.io and 404s too — it sits in "Have a question?",
which is exactly where a reader goes when something did not work. It now
points at the contact form on the site, next to the existing issues link.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The README states the SDK is available under the MIT license and carries
an MIT badge, but the repository has no licence text in any form and the
GitHub API reports `license: null`. The text is the one used in
qonversion-ios-sdk, unchanged. The badge now links to the file instead of
an anchor inside the README.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: qonversion/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2d78c5bc-bc10-49b1-8a77-d12597f276ae

📥 Commits

Reviewing files that changed from the base of the PR and between f83ea12 and ffd85d0.

📒 Files selected for processing (2)
  • LICENSE
  • README.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • qonversion/go-micro (manual)

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds an MIT LICENSE file and updates four README entries: the license badge link, integrations URL, paywalls spelling, and contact form link.

Changes

License and README documentation

Layer / File(s) Summary
License and README documentation
LICENSE, README.md
Adds the MIT license text. Updates README links and corrects the paywalls spelling. The contact link now points to the Qonversion contact form.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to ffd85

The documentation and licensing updates are ready to merge with no identified production impact.

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the README link fixes and LICENSE addition, but it does not name the affected product or system area, such as the Unity SDK. Update the title to include the affected area and outcome, for example: "chore: update Unity SDK README links and add MIT LICENSE".
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Behavior And Regression Safety ✅ Passed PASS. The diff changes only README links, a typo, and the MIT license file. The local LICENSE target exists, and both new external URLs returned HTTP 200. No executable behavior, assertion, safety g…
Security And Tenant Isolation ✅ Passed The pull request changes only README.md and a new non-executable LICENSE file. The changes update links, correct a typo, and add MIT license text. The authoritative diff shows no authentication, autho…
Contract And Data Compatibility ✅ Passed The authoritative diff changes only README.md and adds LICENSE. The README edits are links, a typo, and badge text. The new file contains MIT license text. No API, event, database, configuration, queu…
Rollout And Recovery Evidence ✅ Passed The pull request changes only README links, README wording, and adds a LICENSE text file. The diff contains no production code, configuration, infrastructure, deployment, or migration changes. The rol…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant