FROMLIST: wifi: ath12k: Fix missing station power save configuration

[GaoleZhangHaha]

Commit afbab6e ("wifi: ath12k: modify ath12k_mac_op_bss_info_changed() for MLO") replaced the bss_info_changed() callback with vif_cfg_changed() and link_info_changed() to support Multi-Link Operation (MLO). As a result, the station power save configuration is no longer correctly applied in ath12k_mac_bss_info_changed().

Move the handling of 'BSS_CHANGED_PS' into ath12k_mac_op_vif_cfg_changed() to align with the updated callback structure introduced for MLO, ensuring proper power-save behavior for station interfaces.

Tested-on: WCN7850 hw2.0 PCI WLAN.IOE_HMT.1.1-00011-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1

Fixes: afbab6e ("wifi: ath12k: modify ath12k_mac_op_bss_info_changed() for MLO")

Link: https://lore.kernel.org/all/20250908015025.1301398-1-miaoqing.pan@oss.qualcomm.com/

CRs-Fixed: 4636128

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #910 — validate-patch

PR: #910

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

1. Lore link present: Yes - https://lore.kernel.org/all/20250908015025.1301398-1-miaoqing.pan@oss.qualcomm.com/
2. Lore link matches PR commits: Yes - diff content identical; line number shifts and EXPORT_SYMBOL preservation are legitimate context adaptations
3. Upstream patch status: ✅ ACKed - Reviewed-by Baochen Qiang on 2025-09-08; applied by Jeff Johnson as commit 4b66d18918f8 to ath-current tree
4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #910 - FROMLIST: wifi: ath12k: Fix missing station power save configuration
Upstream commit: https://lore.kernel.org/all/20250908015025.1301398-1-miaoqing.pan@oss.qualcomm.com/
Verdict: ✅ PASS

Commit Message

Check	Status	Note
Subject matches upstream	✅	Subject correctly prefixed with FROMLIST:
Body preserves rationale	✅	Commit message identical to lore patch
Fixes tag present/correct	✅	Fixes: afbab6e4e88d present and correct
Authorship preserved	✅	Original author Miaoqing Pan preserved in From:; submitters added their Signed-off-by: correctly per FROMLIST: rules
Backport note (if applicable)	N/A	Not a backport - FROMLIST: prefix indicates patch posted to mailing list

Diff

File	Status	Notes
drivers/net/wireless/ath/ath12k/mac.c	✅	Code changes identical; line number shifts (4078→4356, 4147→4425, etc.) due to context differences in target tree; EXPORT_SYMBOL correctly preserved in PR's target tree (not present in lore's base tree)

Verdict

Merge as-is. The patch faithfully represents the lore upstream with only legitimate context adaptations.

Final Summary

1. Lore link present: Yes - https://lore.kernel.org/all/20250908015025.1301398-1-miaoqing.pan@oss.qualcomm.com/
2. Lore link matches PR commits: Yes - diff content identical; line number shifts and EXPORT_SYMBOL preservation are legitimate context adaptations
3. Upstream patch status: ✅ ACKed - Reviewed-by Baochen Qiang on 2025-09-08; applied by Jeff Johnson as commit 4b66d18918f8 to ath-current tree
4. PR present in qcom-next/topics: Yes - present in qcom-next as 9325222d9c95 (exact patch-id match per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] FROMLIST: wifi: ath12k: Fix missing station power save	present - exact patch-id match at 9325222	skipped - not checked because qcom-next already contains the change	present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 0/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

[qlijarvis]

PR #910 — checker-log-analyzer

PR: #910
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31080062804

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 warning: long line in commit body (Tested-on line)
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Content mismatch with lore link
tag-check	N/A	Skipped - target branch is qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #910 - FROMLIST: wifi: ath12k: Fix missing station power save configuration
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31080062804
Target branch: qcom-next (commit already present at 9325222)

Checker	Result	Summary
checkpatch	❌	1 warning: long line in commit body (Tested-on line)
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Content mismatch with lore link
tag-check	N/A	Skipped - target branch is qcom-next

---

❌ checkpatch

Root cause: The Tested-on: line in the commit body exceeds the recommended 75-character limit for commit message lines.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#17: 
Tested-on: WCN7850 hw2.0 PCI WLAN.IOE_HMT.1.1-00011-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1

2978cc98c8e03700cfff2bfd3f06be629a67e394 total: 0 errors, 1 warnings, 0 checks, 162 lines checked

Fix: This is a false positive that can be safely ignored. The Tested-on: line is a standard metadata tag used in wireless driver patches to document the hardware/firmware version used for testing. While it exceeds 75 characters, it should remain on a single line for parsability. Wrapping it would break the standard format.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 8635749eab9a..2978cc98c8e0

---

❌ check-patch-compliance

Root cause: The patch content in the PR differs from the upstream patch at the provided lore.kernel.org link.

Failure details:

Checking commit: FROMLIST: wifi: ath12k: Fix missing station power save configuration
Change is different from the one mentioned in Link

Analysis: The PR includes two additional Signed-off-by: trailers that are not present in the upstream lore patch:

• Signed-off-by: Daizhuang Bai <daizhuang.bai@oss.qualcomm.com>
• Signed-off-by: Gaole Zhang <gaole.zhang@oss.qualcomm.com>

These additional sign-offs indicate the patch was reviewed/handled by Qualcomm maintainers during the integration process. This is a legitimate adaptation for internal integration and does not affect the functional content of the patch.

Fix: This is acceptable for vendor integration. The additional sign-offs document the internal review chain and do not modify the code changes. The checker's content-match logic is strict and flags any trailer differences, but this is standard practice for vendor trees integrating upstream patches.

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20250908015025.1301398-1-miaoqing.pan@oss.qualcomm.com/ -o /tmp/out
git format-patch -1 2978cc98c8e0 --stdout > /tmp/pr.patch
diff <(grep -E '^[+-]' /tmp/pr.patch | grep -v '^[+-]{3}') <(grep -E '^[+-]' /tmp/out/*.mbx | grep -v '^[+-]{3}')

---

Verdict

Ready to merge — The two checker failures are both acceptable:

1. checkpatch warning: False positive on Tested-on: line length — this is standard wireless driver metadata format
2. check-patch-compliance: Additional Signed-off-by: trailers document internal review chain — standard vendor integration practice

The functional code changes are identical to the upstream patch. No blockers.

[Shiraz Hashim (shashim-quic)]

qcom-6.18.y-checkFailing after 1s — Change Requests Validation Check

check why is this failing.

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4636128 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4636128

Please ensure the CR has a change task associated with at least one of the entities for this branch.