fix(console): emit the saturating state for growing backlog - #12
Closed
albertovincenzi wants to merge 2 commits into
Closed
fix(console): emit the saturating state for growing backlog#12albertovincenzi wants to merge 2 commits into
albertovincenzi wants to merge 2 commits into
Conversation
One sample above the last latched the state for fifteen seconds. Stacked on the live-backlog change, `backlog` now sums every stage source, so a graph that is working is essentially never at zero and moves between polls — 100, 120, 100, 120 re-latches on every upward reading and pins a healthy graph in the Overview's "needs attention" list, warn-coloured, for as long as it is busy. `StatusDot` calls the state "backlog growing faster than the drain". Two consecutive increases is the shortest sequence that can tell that from jitter, and the cadence is not ours to trust either: four views poll this route, a legacy-route navigation samples out of band, and two open tabs double the rate. Also: nothing ever removed an entry from the sample map, and the key is a graph name. `retain` is called from the one route that samples. Claude-Session: https://claude.ai/code/session_012K8u7BEJyd6nDNMCQAgH3z
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
Stacked on #11 because
saturatingis the growing form of its livepacingstate. Review this PR as the additional trend detector only.Problem
The Vue console had complete UI branches for
saturating, but the server never emitted that value. “Needs attention” and “growing backlog” were therefore unreachable regardless of queue growth.Fix
saturatingwhen a non-zero live backlog grows between samples;Review notes for Alice
The first sample is deliberately only
pacing: one depth value cannot establish a trend. The tracker is per Gate process and advisory; admission remains entirely broker-driven. A decrease clears saturation immediately so recovery is visible without waiting out the hold.State priority is
down→saturating→pacing→flowing.Verification
cargo test -p gate-server obs::tests::cargo clippy -p gate-server --all-targets -- -D warningscargo fmt --all -- --check