fix(api): keep re-entry attempts bounded and idempotent - #21
Closed
albertovincenzi wants to merge 1 commit into
Closed
fix(api): keep re-entry attempts bounded and idempotent#21albertovincenzi wants to merge 1 commit into
albertovincenzi wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The re-entry endpoint accepted an explicit attempt that was equal to or lower than the attempt already stamped on the item. A client could therefore reset the counter and keep an item cycling beyond maxAttempts. An untrusted JSON attempt was also cast from u64 to u32 and then incremented, allowing truncation or overflow. Finally, an empty txn made unrelated reports derive the same broker transaction ID and deduplicate each other.
Fix
Dependency
This PR is intentionally based on #8 so re-entry first receives the shared object-payload validation from that PR. The diff for this review is the single follow-up commit.
Review notes for Alice
Skipping forward remains legal: callers may choose a later attempt, but never the current or an earlier one. That keeps the endpoint bounded without forcing the caller to reproduce the exact next value. Duplicate reports of the same item and attempt still derive the same ID and remain idempotent.
Verification