You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Queen limita un batch KV HTTP a 256 operazioni. Il breaker deve scrivere tutti i counter node-wide e il record di audit nella stessa transazione (la garanzia introdotta dalla PR #27), quindi può gestire al massimo 255 chiavi distinte. Finora una dichiarazione con 256+ counter validava correttamente, ma POST .../backoff e il reset fallivano solo a runtime con kv_too_many_ops, lasciando il vendor throttle non applicato.
Fix
nuova validazione breaker-width sopra 255 chiavi unscoped distinte;
il conteggio usa le chiavi compilate: budget con lo stesso sharedKey coerente contano una volta;
test espliciti sui boundary 255 (accettato) e 256 (rifiutato);
guardia runtime per documenti legacy già persistiti, con risposta 422 descrittiva sia su trip sia su reset;
Questa PR è intenzionalmente basata su #27: spezzare il breaker in più batch eliminerebbe il limite ma reintrodurrebbe il bug più grave, cioè un hold senza record (o viceversa). 255 counter + 1 record riempiono esattamente il limite atomico del broker.
This rule is retroactive on documents that are already in the store.
restore and reconcile both go through declare_from_store → declare_locked(.., from_caller = false) → validate_with, with no exception. A single Problem therefore means the graph is not registered on the next restart: its pushes answer 404 and its ingress queue fills behind one WARN line.
#66 draws the line — a stored document is refused only for nodes, paths or a name that cannot become a queue name and a kv key, and everything else is logged and kept running. Suggest basing this PR on it, or merging it first.
For #34 specifically this is not hypothetical: airbnb/content and airbnb/messages in crates/core/tests/testdata/v1_channel_go_graphs.json carry only conditional budgets, and the passthrough remedy in migrate.rs never runs again once a document has been re-saved in v2 shape.
Landed on master via #67 (merge commit 944ee9b) as part of the 62-PR integration — this PR's head commit 9975913 is an ancestor of master. GitHub could not mark it merged automatically because its base is fix/atomic-breaker-trip, not master. Closing as landed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perché
Queen limita un batch KV HTTP a 256 operazioni. Il breaker deve scrivere tutti i counter node-wide e il record di audit nella stessa transazione (la garanzia introdotta dalla PR #27), quindi può gestire al massimo 255 chiavi distinte. Finora una dichiarazione con 256+ counter validava correttamente, ma
POST .../backoffe il reset fallivano solo a runtime conkv_too_many_ops, lasciando il vendor throttle non applicato.Fix
breaker-widthsopra 255 chiavi unscoped distinte;sharedKeycoerente contano una volta;Verifica
cargo test --workspace;cargo clippy --workspace --all-targets -- -D warnings;cargo fmt --allegit diff --check.Dipendenza / nota per Alice
Questa PR è intenzionalmente basata su #27: spezzare il breaker in più batch eliminerebbe il limite ma reintrodurrebbe il bug più grave, cioè un hold senza record (o viceversa). 255 counter + 1 record riempiono esattamente il limite atomico del broker.