Skip to content

fix: preserve edit and lane legacy console routes #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-viola merged 2 commits into from
Sep 7, 2026
Merged

fix: preserve edit and lane legacy console routes #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63baf2
fix: preserve legacy console route suffixes
albertovincenzi Sep 4, 2026
f783804
fix(console): read the edit suffix from the route, not from the URL
albertovincenzi Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions ui/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,27 @@ async function resolveApplication(to) {
// Unreachable API: send it to `default`, which is where the flat control
// route would have looked anyway, and let the page report the failure.
}
return `/apps/${encodeURIComponent(application)}/graphs/${encodeURIComponent(name)}`
return graphLocation(application, name, to)
}

/* The target shapes, kept as addresses and answered by the graph pages. A
`/lanes/:lane` link becomes the graph with that path selected, because a lane
is a path now and the page can show it. */
function toGraph(to) {
const { app, name, lane, path } = to.params
function graphLocation(app, name, to) {
const { lane, path } = to.params
const base = `/apps/${encodeURIComponent(app)}/graphs/${encodeURIComponent(name)}`
const p = lane || path
const q = p ? `?path=${encodeURIComponent(p)}` : ''
return `/apps/${encodeURIComponent(app)}/graphs/${encodeURIComponent(name)}${q}`
if (p) return `${base}?path=${encodeURIComponent(p)}`
/* The suffix comes from the ROUTE PATTERN, never from `to.path`. `ok_name`
admits `edit` as a graph name, so `/targets/edit` ends with `/edit` while
naming no suffix at all — reading the concrete URL sends that graph to the
editor instead of to its detail page. The pattern is static. */
if (to.matched.at(-1)?.path.endsWith('/edit')) return `${base}/edit`
return base
}

function toGraph(to) {
return graphLocation(to.params.app, to.params.name, to)
}

const router = createRouter({
Expand All @@ -65,7 +75,7 @@ const router = createRouter({

// ---- the target addresses, answered by the graph pages.
{ path: '/apps/:app/targets/:name', component: NeverRendered, beforeEnter: toGraph, meta: { nav: 'targets' } },
{ path: '/apps/:app/targets/:name/edit', component: NeverRendered, beforeEnter: (to) => `/apps/${to.params.app}/graphs/${to.params.name}/edit`, meta: { nav: 'targets' } },
{ path: '/apps/:app/targets/:name/edit', component: NeverRendered, beforeEnter: toGraph, meta: { nav: 'targets' } },
{ path: '/apps/:app/targets/:name/lanes/:lane', component: NeverRendered, beforeEnter: toGraph, meta: { nav: 'targets' } },
{ path: '/apps/:app/targets/:name/budgets/:budget', component: NeverRendered, beforeEnter: toGraph, meta: { nav: 'targets' } },

Expand Down
Loading