fix: make shell overview polling single-flight - #50
Closed
albertovincenzi wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dipendenza
Questa PR è impilata su #19 (
fix/single-flight-console-polling), che introduce il composable single-flight e la cancellazione su unmount. Va valutata dopo quella PR; il diff specifico qui riguarda soltantoApp.vue.Problema
La shell della console interrogava
/api/overviewcon unsetIntervalproprio, fuori dausePoll:Anche dopo #19, questo era l'unico polling della console che saltava il gate single-flight.
Fix
usePoll(load, 15000)anche per l'overview della shell;fetchMe, invoca ilrefreshrestituito dal composable;setIntervalmanuale.Il primo tick montato prima dell'autenticazione è innocuo (
loadesce suauthState !== ready); il refresh dopofetchMegarantisce il caricamento immediato. Se i due eventi coincidono, il single-flight di #19 accoda al massimo un solo follow-up.Verifica
cd ui && npm run build(52 moduli trasformati, build Vite riuscita);git diff --check.Per Alice
Dopo il merge di #19, il criterio manuale è semplice: aprire la console, verificare l'overview del broker dopo il login, nascondere/mostrare la tab e controllare un refresh immediato senza richieste concorrenti nel pannello Network.