fix(history): prune checkpoints for removed stages - #51
Closed
albertovincenzi wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dipendenze
Questa PR è impilata su #20, che a sua volta dipende da #13. Il diff aggiuntivo riguarda soltanto il ciclo dei checkpoint; va valutato dopo l'allineamento dei bucket e la persistenza atomica della baseline.
Problema
La mappa
lastconserva la baseline dei contatori lifetime per ogni identità grafo/path/stage. Quando un grafo viene eliminato, disabilita i counters o una redeclare rimuove uno stage, nessuno eliminava la relativa entry:Fix
lastsoltanto quelle chiavi;active;Test
cargo test --workspace;cargo clippy -p gate-server --all-targets -- -D warnings;cargo fmt --all -- --check;git diff --check.Per Alice
L'ordine è #13 → #20 → questa PR. La proprietà importante da controllare è il ramo di errore: un fallimento PostgreSQL non fa avanzare né eliminare il checkpoint di uno stage ancora attivo, quindi il delta verrà ritentato nel minuto successivo come previsto da #13.