fix: reject unstampable payloads before shared routing - #56
Closed
albertovincenzi wants to merge 1 commit into
Closed
fix: reject unstampable payloads before shared routing#56albertovincenzi wants to merge 1 commit into
albertovincenzi wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Gate uses the reserved _gate.path field to decide which path group owns a frame on a shared interior queue. JSON scalars and arrays cannot carry that field. The relay nevertheless forwarded them, so the compiler-selected unstamped owner could charge and route every copy as the wrong path after a convergence.
This is data-plane corruption rather than a presentation issue: the payload may leave through the wrong continuation and its traffic is attributed to the wrong path.
Fix
Verification
Review / dependency
This PR is intentionally stacked on #25 because it extends the message-classification path introduced there. Review commit 6994cd2 relative to fix/enforce-applicable-scoped-budgets. Merge order: #10, then #25, then this PR.