fix: refresh Google keys when kid rotates - #57
Closed
albertovincenzi wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The JWKS cache returned any cached key set for a fixed hour. When Google rotated signing keys and issued a token with a new kid during that hour, Gate answered no matching key and rejected every affected login until the TTL elapsed or the process restarted.
The fetch path also accepted non-success HTTP responses and any JSON object as a cacheable key set, which could turn a transient upstream error into the same one-hour outage.
Fix
Verification
Unit tests cover a rotated key appearing after refresh, a cache hit that performs no refresh, and an unknown key that stops after one retry.
Review / dependency
This PR is stacked on #40 to avoid conflicts with the already-separated OAuth hardening series. Review commit 61f0b68 relative to fix/protect-logout. Merge order: #15, #31, #39, #40, then this PR.