fix: validate shared breaker records - #58
Closed
albertovincenzi wants to merge 1 commit into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Breaker records live in the shared broker namespace and were deserialized without validating the invariants Gate applies when it creates them. A malformed or future record could carry a negative or enormous retryAfterSeconds value. Three read paths then computed at + retryAfterSeconds * 1000 with ordinary signed arithmetic: debug builds can panic, release builds can wrap to a false deadline, and the console may report corrupt state as a live breaker.
Fix
Verification
Unit tests cover a deadline at the i64 boundary and reject zero, oversized, and negative-timestamp records.
Review / dependency
This PR is stacked on #44 because it consolidates the ETA overflow guard introduced there into the Record method. Review commit a5d5f9e relative to fix/saturating-eta-arithmetic. Merge order: #44, then this PR.