Stop reporting unknown queue depth as zero - #61
Closed
albertovincenzi wants to merge 2 commits into
Closed
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Queue depth is live broker state, but the cache currently turns a failed first read into an empty map and serves an expired successful value after later failures. Both are returned as current data.
That makes an unavailable depth endpoint look like backlog zero. The topology can appear empty even while work is queued, and ETA can become immediately available or too optimistic because it is calculated from a stale, lower backlog.
The JSON decoders also default missing partition names or pending values to empty strings and zero, so broker/API schema drift has the same misleading result.
Fix
Before / after
Before: a depth outage could produce HTTP 200 with backlog 0 or an unlabelled stale value.
After: fresh cached values remain available for two seconds; after expiry, an unreadable depth produces HTTP 502 until Queen answers again. A confirmed missing queue still has backlog zero.
Verification
Review / dependency
This PR is intentionally based on #59, which introduces the common HTTP 502 mapping for unreadable live broker state. Review commit 59b9926 as this complete fix. It can be rebased after #59 lands.