Skip to content

Derive Eq for ProtocolType - #194

Merged
benjajaja merged 1 commit into
ratatui:masterfrom
VAWVAW:protocol-type-eq
Sep 3, 2026
Merged

benjajaja merged 1 commit into
ratatui:masterfrom
VAWVAW:protocol-type-eq

Conversation

@VAWVAW

@VAWVAW VAWVAW commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

I want to use ProtocolType in an iamb type that needs it to be Eq. I don't see how deriving this could lead to any problems.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Merge of fa58c74 to master

Screenshots from all terminal emulators:

alacritty

alacritty screenshot

Image diff vs master:
alacritty diff

blackbox

blackbox screenshot

Image diff vs master:
blackbox diff

contour

contour screenshot

Image diff vs master:
contour diff

foot

foot screenshot

Image diff vs master:
foot diff

ghostty

ghostty screenshot

Image diff vs master:
ghostty diff

kitty

kitty screenshot

Image diff vs master:
kitty diff

konsole

konsole screenshot

Image diff vs master:
konsole diff

mlterm

mlterm screenshot

Image diff vs master:
mlterm diff

rio

rio screenshot

Image diff vs master:
rio diff

wezterm

wezterm screenshot

Image diff vs master:
wezterm diff

xfce4-terminal

xfce4-terminal screenshot

Image diff vs master:
xfce4-terminal diff

xterm

xterm screenshot

Image diff vs master:
xterm diff

xterm-vt340

xterm-vt340 screenshot

Image diff vs master:
xterm-vt340 diff

@benjajaja

Copy link
Copy Markdown
Collaborator

/merge

@benjajaja
benjajaja merged commit fa58c74 into ratatui:master Sep 3, 2026
19 checks passed
@benjajaja

Copy link
Copy Markdown
Collaborator

@VAWVAW may I ask why? I feel like everytime a user needs to deal with ProtocolType, the library has failed in some way.

@VAWVAW

VAWVAW commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for merging this.

iamb exposes a ProtocolType and FontSize setting, because afaict Picker::from_query_stdio() doesn't work on windows (see ulyssa/iamb#653). I am implementing ulyssa/iamb#578 which needs all values that are changed to be Eq.

The only actual usecase I can think of is having a tmux session open in multiple terminals that support different protocols.

@VAWVAW
VAWVAW deleted the protocol-type-eq branch September 3, 2026 12:40
@benjajaja

Copy link
Copy Markdown
Collaborator

Ah right. I always thought that it would be best if we could remove the ability to configure the protocol_type etc in iamb. Otherwise some users might have some old configuration that isn't needed anymore (has been fixed upstream).

This branch is waiting to be deployed

1 waiting deployment
release — fa58c748 Waiting Sep 3, 2026 by benjajaja via Release-plz release #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants