Skip to content

Enhance scroll functionality - #5

Open
wenujacodes wants to merge 2 commits into
rbc33:mainfrom
wenujacodes:main
Open

Enhance scroll functionality#5
wenujacodes wants to merge 2 commits into
rbc33:mainfrom
wenujacodes:main

Conversation

@wenujacodes

Copy link
Copy Markdown
Contributor

This pull request introduces an option to restrict haptic feedback to only scrollable content, improves accessibility detection for scrollable regions, and updates project configuration to disable code signing and remove the development team requirement. It also updates localization files to support the new menu item. Fixed #4

New feature: Only scrollable content haptics

  • Added a toggle in the app menu to enable or disable haptic feedback only when the cursor is over scrollable content (AppDelegate.swift, Localizable.strings) [1] [2] [3] [4].
  • Introduced the onlyScrollableContent property to ScrollHapticEngine, persisted via UserDefaults.
  • Updated scroll event handling to check scrollability before triggering haptics.

Accessibility: Scrollability detection

  • Added new ScrollabilityDetector class that uses macOS Accessibility APIs to determine if the current cursor location is within a scrollable region, with caching for responsiveness (ScrollabilityDetector.swift).
  • Integrated ScrollabilityDetector into ScrollHapticEngine.

Build and code signing configuration

  • Changed code signing to manual and disabled code signing identity and development team in Xcode project files, project.xml, and build.sh for easier building and distribution without a team profile [1] [2] [3] [4] [5] [6] [7] [8] [9].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Haptic feedback triggers when scrolling even when there is no content to scroll

1 participant