RM-9726 Add primary key constraint to TVPs used for Batched Sql Commands - #1444
Open
dkudernatsch wants to merge 3 commits into
Open
RM-9726 Add primary key constraint to TVPs used for Batched Sql Commands#1444dkudernatsch wants to merge 3 commits into
dkudernatsch wants to merge 3 commits into
Conversation
MichaelKetting
requested changes
Aug 17, 2026
MichaelKetting
approved these changes
Aug 25, 2026
| @@ -607,13 +607,15 @@ CREATE TYPE [dbo].[TVP_Guid_Distinct] AS TABLE | |||
| GO | |||
Member
There was a problem hiding this comment.
Please rebase on top of develop. We shouldn't have the merge of develop into the PR.
Also, please add a short description as branch name for future branches. TIcket-ID-only branches aren't a thing in re-motion. We can possibly fix this during merge this time, too.
I think we can flatten the two commits into a signle one. The changes are just cleanup not separate items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.