Add back RectorConfig::tag() as a no-op BC layer - #8431
Merged
Conversation
The DI container switch to entropy removed the tag() method inherited from illuminate/container. Older configs and sets still call it, causing "Call to undefined method Rector\Config\RectorConfig::tag()". Restore it as a deprecated no-op, since services are now discovered by contract. Claude-Session: https://claude.ai/code/session_01SPWpEgoaHa33ypRUWccHHr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9880
The DI container switch to entropy (#8362) dropped the
tag()method that used to be inherited fromilluminate/container. Configs and sets that still call->tag()now blow up with:even when the project never calls it directly (a set does).
This restores
tag()as a deprecated no-op. Tagging is not needed anymore - the entropy container discovers services by contract - so the call is simply accepted and ignored to keep BC.https://claude.ai/code/session_01SPWpEgoaHa33ypRUWccHHr