[TypeDeclarationDocblocks] Return empty "[]" as "mixed[]" instead of "array{}" on bare "@return array" - #8432
Merged
Conversation
…rn []" into "mixed[]" instead of "array{}"
Claude-Session: https://claude.ai/code/session_011MyFdoaYnfDEvdM9o3kiyq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a method has a bare
@return arraydocblock and its sole body statement isreturn [];,DocblockReturnArrayFromDirectArrayInstanceRectorpreviously rewrote it to@return array{}.array{}describes an always-empty array shape, which is rarely the intent for a method that just happens to return[]in one branch. This turns that case into the looser, more usefulmixed[]:Scope kept narrow on purpose:
@return arraytag (not@return mixed,iterable, or an existing generic),return [],@return mixed[]and typedX[]empties keep being skipped, and no-docblock empties keep generalizing as before.https://claude.ai/code/session_011MyFdoaYnfDEvdM9o3kiyq