[TypeDeclarationDocblocks] Guard DocblockVarArrayFromPropertyDefaultsRector against unsound narrowing - #8435
Open
TomasVotruba wants to merge 1 commit into
Open
[TypeDeclarationDocblocks] Guard DocblockVarArrayFromPropertyDefaultsRector against unsound narrowing#8435TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…Rector against unsound narrowing Two cases produced a @var narrower than the values actually stored: - non-private property: a child class can reassign it with a wider type that is invisible from the declaring class, so restrict to private - empty nested array default (e.g. ['create' => [], 'update' => []]): generalizes to never[], which then rejects every real value assigned later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cases produced a
@varnarrower than the values actually stored in the property.Non-private property - a child class can reassign it with a wider type that is invisible from the declaring class:
Empty nested array default - e.g.
['create' => [], 'update' => []]generalizes tonever[], which then rejects every real value assigned later:Restrict to private properties and skip empty nested array defaults. The existing
array_union_generic_same_typefixture used a protected property; converted to private to keep the transform meaningful.