[TypeDeclarationDocblocks] Only touch private methods in AddParamArrayDocblockFromAssignsParamToParamReferenceRector - #8436
Open
TomasVotruba wants to merge 1 commit into
Open
Conversation
…yDocblockFromAssignsParamToParamReferenceRector A by-ref array param type is invariant in PHPStan: narrowing it below array makes every caller passing a plain array fail. For a protected or public method those callers live outside the class and are invisible here, so restrict the rule to private methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A by-ref array param type is invariant in PHPStan. Narrowing it below
arraymakes every caller passing a plainarrayfail:For a protected or public method those callers live outside the class and are invisible here, so restrict the rule to private methods. The public
run()fixtures are converted to private.