[TypeDeclarationDocblocks] Limit ClassMethodArrayDocblockParamFromLocalCallsRector to private methods - #8442
Merged
Conversation
…alCallsRector to private methods Only private methods have a closed set of local callers, so the inferred @PARAM array type is safe. Public and protected methods can be called from outside the class, where the argument types are unknown. Claude-Session: https://claude.ai/code/session_01DCgCmqW1U7rcp5nuhXNtaC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict
ClassMethodArrayDocblockParamFromLocalCallsRectorto private methods only.Only private methods have a closed set of local callers, so the
@paramarray type inferred from local$this->method(...)calls is safe. Public and protected methods can be called from outside the class (child classes, external callers), where the real argument types are unknown, so inferring a narrow type from local calls alone is unsound.The parent/interface LSP guard and the public
mixed[]special case are now dead and removed. Protected/public fixtures are converted to skip fixtures.https://claude.ai/code/session_01DCgCmqW1U7rcp5nuhXNtaC