Skip to content

fix(providers): restore keyless live smoke#16

Merged
MyPrototypeWhat merged 6 commits into
mainfrom
m13t/fix-live-smoke-providers
Jul 13, 2026
Merged

fix(providers): restore keyless live smoke#16
MyPrototypeWhat merged 6 commits into
mainfrom
m13t/fix-live-smoke-providers

Conversation

@MyPrototypeWhat

Copy link
Copy Markdown
Collaborator

What changed

  • Restrict Internet Archive searches upstream to the movies and texts media types the provider can map.
  • Translate PoetryDB's normalized query limit into the documented poemcount route while preserving explicit poemCount, random, paired fields/terms, and bounded fallbacks.
  • Remove Rijksmuseum's unsupported pageSize parameter and consume the current one-hop edm-framed JSON-LD representation.
  • Leave Gutendex behavior unchanged because the original 403 was not reproducible as a provider defect.

Why

The first scheduled keyless live-smoke run exposed three deterministic upstream-contract drifts:

  • Internet Archive applied the row cap before the provider's local media-type filter, so supported results could be excluded.
  • PoetryDB received an unbounded broad line search because q.limit was not sent upstream, producing a 503.
  • Rijksmuseum rejected pageSize; its la profile now returns N-Triples rather than JSON.

Impact

The affected keyless providers now issue bounded, current-contract requests and retain their existing normalized Reference, ID, rights, and local result-limit semantics.

Validation

  • Targeted provider tests: 41 passed
  • Full test suite: 337 passed, 22 opt-in live tests skipped
  • pnpm typecheck
  • pnpm build
  • git diff origin/main...HEAD --check
  • Internet Archive live smoke passed
  • Rijksmuseum live smoke passed
  • Final independent branch review: ready to merge, no findings

PoetryDB and Gutendex live tests could not establish a TCP connection to their Cloudflare addresses from the local runner (ETIMEDOUT / EHOSTUNREACH, before any HTTP response). PoetryDB's generated route is covered by URL tests and matches the official poemcount contract; both live checks should be rerun on GitHub Actions.

@MyPrototypeWhat MyPrototypeWhat marked this pull request as ready for review July 13, 2026 08:10
@MyPrototypeWhat MyPrototypeWhat merged commit 221b1d3 into main Jul 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant