Conversation
Approvals are now only treated as satisfied if they were submitted against the release PR's current head commit. If new commits land after someone approves, they're re-requested instead of staying excluded indefinitely.
CI failed on no-restricted-syntax / no-continue (Airbnb config). Rewrote the latest-review lookup with reduce/forEach instead.
Covers two contributors who both approved, then one of them lands another commit — verifies the other reviewer's still-current approval is left alone while only the stale one is re-requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background 📜
The release PR bot was not properly handling cases where reviewers had approved previous commits but the PR head had moved forward. It would incorrectly exclude these reviewers from re-request lists, even though their approval was no longer valid for the current commit.
Changes 📝
Checklist ✅
https://claude.ai/code/session_01HwygAUrQrgCXADGUVPKEgf