Skip to content

chore(deps): bump solana-transaction from 3.1.0 to 4.0.0 - #11

Merged
WomB0ComB0 merged 2 commits into
mainfrom
dependabot/cargo/solana-transaction-4.0.0
Mar 30, 2026
Merged

WomB0ComB0 merged 2 commits into
mainfrom
dependabot/cargo/solana-transaction-4.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Mar 24, 2026

Copy link
Copy Markdown
Contributor

Bumps solana-transaction from 3.1.0 to 4.0.0.

Release notes

Sourced from solana-transaction's releases.

instruction@v3.3.0

What's new

account-info@v3.1.1

What's new

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added dependencies Automated dependency updates rust Rust dependency updates labels Mar 24, 2026
@github-actions github-actions Bot added the size/XS Extra-small PR (fewer than 10 lines changed) label Mar 24, 2026
Bumps [solana-transaction](https://github.com/anza-xyz/solana-sdk) from 3.1.0 to 4.0.0.
- [Release notes](https://github.com/anza-xyz/solana-sdk/releases)
- [Commits](https://github.com/anza-xyz/solana-sdk/compare/msg@v3.1.0...sdk@v4.0.0)

---
updated-dependencies:
- dependency-name: solana-transaction
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/cargo/solana-transaction-4.0.0 branch from 986c860 to 0ecd4e0 Compare March 24, 2026 17:39
@WomB0ComB0

Copy link
Copy Markdown
Member

⚠️ Breaking Change — Do Not Merge Without Code Fix

solana-transaction v4.0.0 introduces breaking API changes. The validate CI job is failing with:

error: could not compile `resq-airspace` (lib) due to 9 previous errors

The AnchorDeserialize derive macro is failing because the trait bounds required by solana-transaction v4 are not satisfied by the current program code. This requires updating the affected programs to use the new v4 API before merging.

Action needed: Update resq-airspace (and any other affected programs) to be compatible with solana-transaction v4.0.0 before merging this PR.

borsh 1.x (pulled in by solana-transaction 4.0.0) requires
#[borsh(use_discriminant=true/false)] on enums with explicit numeric
discriminants. Anchor 1.0.0-rc.5's derive macros (AnchorSerialize /
AnchorDeserialize) consume the helper attribute twice, causing a
'multiple borsh attributes' compile error.

Fix: remove the explicit `= 0/1/2/3` assignments from AccessPolicy.
The implicit discriminants are identical in value and order, so the
on-chain wire format is unchanged and all existing accounts remain
readable without a migration.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@WomB0ComB0
WomB0ComB0 merged commit 6d46469 into main Mar 30, 2026
4 checks passed
@github-actions github-actions Bot added size/S Small PR (10-29 lines changed) program:airspace and removed size/S Small PR (10-29 lines changed) size/XS Extra-small PR (fewer than 10 lines changed) labels Mar 30, 2026
@dependabot
dependabot Bot deleted the dependabot/cargo/solana-transaction-4.0.0 branch March 30, 2026 12:21
WomB0ComB0 added a commit that referenced this pull request Mar 30, 2026
…infra compat

solana-program-test 3.1.10 (vendored) uses solana-banks-client 3.1.10
which is tied to solana-account 3.4.0 and solana-transaction 3.1.0.
Bumping the workspace deps to 4.x creates type incompatibilities in
integration tests:

- `ProgramTest::add_account` expects solana-account 3.x Account
- `BanksClient::process_transaction` expects solana-transaction 3.x
  Transaction/VersionedTransaction

Revert both to 3.x until solana-program-test is updated to a version
that uses solana-banks-client 4.x (which supports 4.x modular types).

The borsh enum discriminant fix in airspace_account.rs (from PR #11)
is retained — that code change is still required for borsh 1.x compat
regardless of solana-transaction version.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
WomB0ComB0 added a commit that referenced this pull request Jun 2, 2026
#32)

* ci(security): harden security workflow — clear zizmor alerts #10 & #11

Resolves both open code-scanning alerts on .github/workflows/security.yml
(zizmor 1.24.1, verified locally with `zizmor --persona=auditor`):

- #11 secrets-inherit (warning): replace `secrets: inherit` — which hands
  the reusable workflow ALL of this repo's secrets — with named forwarding
  of just SEMGREP_APP_TOKEN (the only enabled token-consuming scanner).
  Enabled by resq-software/.github#21, which declares the secret under
  workflow_call.secrets; re-pinned to that workflow's new SHA
  (b48036af, #21).
- #10 unpinned-uses (error): already SHA-pinned in #30; carried forward.

Also clears two latent findings the stale scan predates:
- excessive-permissions: drop workflow-level `permissions` to `{}` and move
  contents/security-events/pull-requests scopes onto the `scan` job, so they
  apply only to the reusable call.
- undocumented-permissions: every scope now carries an explanatory comment.

`zizmor --no-online-audits` reports "No findings" on the result.

NOTE: this does not by itself explain the separate scheduled-run
startup_failure (which persisted after the #30 pin); switching off
`secrets: inherit` is the leading remaining hypothesis and this PR tests it.

* fix(ci): grant actions:read so the security reusable can start

Root cause of the security-workflow startup_failure (every run since
2026-05-04, 0 jobs executed): the reusable security-scan.yml's CodeQL and
zizmor jobs request `actions: read` (added in resq-software/.github#20,
2026-05-04 — exactly when the failures began). A reusable workflow's jobs
cannot request a permission the caller did not grant; GitHub rejects the
entire run at startup.

The prior #30 SHA-pin and the secrets-inherit removal did not fix it
because neither granted actions:read. Add it to the scan job's permissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Automated dependency updates program:airspace rust Rust dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant