chore(nix): bump nixpkgs 24.11 → 25.11 + refresh lock - #18
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 52 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the nixpkgs input in flake.nix from version 24.11 to 25.11 and introduces the corresponding flake.lock file. Feedback suggests optimizing the flake evaluation by ensuring the rust-overlay input follows the main nixpkgs input, which would prevent the inclusion of multiple nixpkgs versions in the dependency graph and reduce closure size.
|
|
||
| inputs = { | ||
| nixpkgs.url = "github:nixos/nixpkgs/nixos-24.11"; | ||
| nixpkgs.url = "github:nixos/nixpkgs/nixos-25.11"; |
There was a problem hiding this comment.
To optimize the flake evaluation and reduce the closure size, it is recommended to make the rust-overlay input follow the main nixpkgs input. This prevents Nix from fetching and evaluating two different versions of nixpkgs (the stable 25.11 and the unstable version used by default by the overlay). Currently, the flake.lock shows that rust-overlay is pulling in an additional nixpkgs-unstable instance.
nixpkgs.url = "github:nixos/nixpkgs/nixos-25.11";
rust-overlay.inputs.nixpkgs.follows = "nixpkgs";
Bumps nixpkgs channel 24.11 → 25.11 (current stable) and refreshes flake.lock. Closes the reproducibility gap — repos without a committed lockfile now have one, and the shared channel matches across the org.
Mechanical: no changes to devPackages or shellHook.
🤖 Generated with Claude Code