Skip to content

Refactor styles and add ArcRendering component (#421) - #422

Draft
pkd2512 wants to merge 2 commits into
mainfrom
arc-config
Draft

Refactor styles and add ArcRendering component (#421)#422
pkd2512 wants to merge 2 commits into
mainfrom
arc-config

Conversation

@pkd2512

@pkd2512 pkd2512 commented Jun 4, 2026

Copy link
Copy Markdown
Member

What's in this pull request

Refactors the SCSS reset and typography layers and introduces the new ArcRendering component. Addresses issue #421 and follows on from #420.

Style refactoring (src/scss/reset/_typography.scss, src/scss/reset/_main.scss, src/scss/main.scss):

  • Replaced hardcoded #404040 with the $theme-colour-text-primary design token for consistent theming.
  • Made the SVG text selector explicit (svg text) and documented intent — it now clearly targets chart/visualization text rather than colliding with the HTML namespace.
  • Removed redundant display: block declarations on p, ol, ul (block-level by default).
  • Consolidated cascade fragmentation: nested li::marker inside li using &::marker; grouped list-style-type rules and made ol explicit.
  • Standardized @include ordering (mixins → properties → nested selectors) across .theme, kbd, and the typography root.
  • Added clarifying comments on the 0.9 font-size multiplier and the nested-blockquote pattern.
  • Moved font-smoothing declarations from scoped to root-level for global coverage.

New ArcRendering component (src/components/ArcRendering/):

  • Component, stories and MDX docs for rendering Arc-shell pages.
  • Article updated to conditionally skip the <main> wrapper when inside an Arc shell.
  • Storybook Wrapper updated to support the new rendering path.

Before submitting, please check that you've

  • Read our contributing guide
  • Documented any new components or features (ArcRendering.mdx)
  • Tagged an editor to review this PR

@changeset-bot

changeset-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3cbd47f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jun 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@reuters-graphics/graphics-components@422

commit: 3cbd47f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant