Refactor styles and add ArcRendering component (#421) - #422
Draft
pkd2512 wants to merge 2 commits into
Draft
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this pull request
Refactors the SCSS reset and typography layers and introduces the new
ArcRenderingcomponent. Addresses issue #421 and follows on from #420.Style refactoring (
src/scss/reset/_typography.scss,src/scss/reset/_main.scss,src/scss/main.scss):#404040with the$theme-colour-text-primarydesign token for consistent theming.textselector explicit (svg text) and documented intent — it now clearly targets chart/visualization text rather than colliding with the HTML namespace.display: blockdeclarations onp,ol,ul(block-level by default).li::markerinsideliusing&::marker; groupedlist-style-typerules and madeolexplicit.@includeordering (mixins → properties → nested selectors) across.theme,kbd, and the typography root.0.9font-size multiplier and the nested-blockquote pattern.New
ArcRenderingcomponent (src/components/ArcRendering/):Articleupdated to conditionally skip the<main>wrapper when inside an Arc shell.Wrapperupdated to support the new rendering path.Before submitting, please check that you've
ArcRendering.mdx)