Stop contributor comments rendering as page text - #89
Merged
Merged
Conversation
Django's {# … #} is a single-line comment. Five of them in the templates
spanned several lines, which leaves the closing marker unmatched and puts
the whole note on the page as visible text:
workspaces/map.html the street-space layer note under "Show target
areas", and the Vision Zero note in the target
form
workspaces/methodology.html the area-target section note
datasets/_provenance_badge.html
datasets/catalog_browse.html
datasets/_test_panel.html
All five are now {% comment %} … {% endcomment %}, which is the multi-line
form. Two came in with the target-areas feature; the other three predate
it.
Verified by rendering: all 28 templates parse, and no {# without a closing
#} on the same line remains anywhere under backend/templates. Full suite:
342 tests, the same 13 pre-existing failures. ruff 0.15.8 clean.
VERSION 0.48.2 -> 0.48.3 (PATCH: bug fix). CHANGELOG and README badge
updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django's
{# … #}is a single-line comment. Five comments in the templates spanned several lines, which leaves the closing marker unmatched and puts the whole note on the page as visible text.Spotted in a screenshot of the map: the target-area panel was showing
{# The street-space layers are among the heaviest a workspace has, so they are offered rather…to the viewer.workspaces/map.htmlworkspaces/map.htmlworkspaces/methodology.htmldatasets/_provenance_badge.htmldatasets/catalog_browse.htmldatasets/_test_panel.htmlAll are now
{% comment %} … {% endcomment %}, which is the multi-line form. Two came in with the target-areas feature (#86); the other three predate it — the provenance badge appears on every data-source row, so that one was on screen a lot.Also removes a redundant
syncAccidentLayers()call added in #88 next to the one the accidents branch already makes.Verification
grep -rn "{#" backend/templates/ | grep -v "#}"returns nothing, so no multi-line comment remains anywhere in the template tree.ruff 0.15.8clean.Still open
This does not address the accidents heatmap still rendering empty after #88. The layer now downloads completely (
200, 24.49 MB, 2.08 MB over the wire), so the remaining problem is on the display or filter side, not the transport side. That is being investigated separately.Governance
VERSION0.48.2 → 0.48.3 (PATCH — bug fix only).CHANGELOG.mdunder[Unreleased] / Fixed, README badge synced.Generated by Claude Code