Skip to content

feat: add Storybook stories for VestingBar and VestingClock - #927

Open
Ademiitura wants to merge 6 commits into
ritik4ever:mainfrom
Ademiitura:feature/storybook-docs
Open

feat: add Storybook stories for VestingBar and VestingClock#927
Ademiitura wants to merge 6 commits into
ritik4ever:mainfrom
Ademiitura:feature/storybook-docs

Conversation

@Ademiitura

Copy link
Copy Markdown
Contributor

Commit Type

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (formatting, etc.)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing or correcting existing tests
  • build: Changes affecting the build system or external dependencies
  • ci: Changes to CI/CD configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Breaking change? (If yes, add BREAKING CHANGE in the commit footer)

  • Yes — this contains a breaking change
  • No

What changed

  • Added Storybook stories for VestingBar and VestingClock. Neither component existed in the codebase — both were built based on inference from the app's domain (payment streaming on Stellar) and existing time/progress display patterns in StreamTimeline and StreamMetricsChart. Open to adjusting to match any actual intended design.
  • Restored frontend/package.json and package-lock.json, which were empty on main and blocked npm install / any local frontend setup entirely.

Testing done

  • Ran Storybook locally (npm run storybook) and manually verified all existing component stories still render correctly (StreamsTable, StreamTimeline, WalletButton, CreateStreamForm, StreamDetailDrawer, CopyableAddress, FilterBar).
  • Verified all three states for VestingBar (not started, in progress, fully vested) and VestingClock (counting down, ending soon, complete) render as expected.

Related issues

Closes #759

Checklist

  • I used the correct commit type (see above) for the squashed commit message.
  • I kept the change focused on the related issue.
  • I added or updated tests where useful.
  • I updated documentation where behavior changed.
  • I verified the app still builds or explained why verification was skipped.
  • My commits follow Conventional Commits (enforced by commitlint).

Also restores frontend/package.json and package-lock.json, which were
empty on main and blocked local setup entirely.
vite-plugin-pwa's service worker generation crashes during
build-storybook due to a workbox-build/ajv-errors incompatibility.
Not needed for Storybook previews, so it's filtered out via viteFinal.
@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

@Ademiitura is attempting to deploy a commit to the ritik4ever's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@Ademiitura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a68f4ef-72b6-4438-bb33-a47f6f125eeb


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

- SenderDashboard.tsx: restore missing 'if' condition that caused a
  syntax error at end of file
- StreamsTable.stories.tsx / WalletButton.stories.tsx: update mock
  data to match current Stream and FreighterState type shapes
@Ademiitura

Copy link
Copy Markdown
Contributor Author

Type check is failing in CI due to a pre-existing issue unrelated to this PR:

src/App.tsx:2:72 - error TS2307: Cannot find module 'react-router-dom' or its corresponding type declarations.

This also reproduces on main directly (confirmed locally via git stash + npx tsc --noEmit), so it's not something introduced by this branch. Looks like react-router-dom is imported in App.tsx but isn't listed in package.json's dependencies.

While digging into CI, also found and fixed two other pre-existing issues so this PR could get a clean type-check locally:

  • SenderDashboard.tsx had a missing if condition causing a syntax error at the end of the file
  • StreamsTable.stories.tsx and WalletButton.stories.tsx had mock data that didn't match the current Stream/FreighterState type shapes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Storybook for component documentation

1 participant