fix(release): verify published tags after the staging cleanup - #1622
Merged
Merged
Conversation
The verify-published job only needed docker and promote, so it could run beside cleanup-staging instead of after it. That cleanup deletes the package version when it reads only the staging tag on it, and GHCR's package-versions API is eventually consistent, so the check that exists to catch a deleted release tag could pass before the deletion happened. Also skips an imported sessions row whose id is not a safe path key: the id now names the on-disk auth directory, so an unvalidated one would only surface later as a refused start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify-publishedis the check that catches a release tag that is missing or points at the wrong digest, and the comment above it names the incident it exists for. It only neededdockerandpromote, so it could run besidecleanup-stagingrather than after it. That cleanup deletes the package version when it reads only the staging tag on it, and GHCR's package-versions API is eventually consistent, so the deletion this check guards against could happen after the check had already passed.verify-publishednow also needscleanup-staging, and runs wheneverpromotesucceeded, so a best-effort cleanup failure cannot suppress it.idis not a safe path key, the same way it already skips an unsafename: the id now names the on-disk auth directory, so an unvalidated one would surface later as a refused start instead of a skipped row with a reason.Verification:
actionlintis clean, the new importer spec fails without the id guard, and lint,tsc --noEmit,format:check,test:cov(6382 tests) andtest:docspass locally.