Fix return-direct terminal tool completion - #389
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9459f4be2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return returnDirectCompletion | ||
| ? AgentRunFinisher.finishToolResult( |
There was a problem hiding this comment.
Avoid persisting an unfulfillable checkpoint reminder
When the normal read-and-record tool profile includes memory_checkpoint, any successful non-memory tool makes AgentMemoryCheckpointTracker.trackCheckpointNeed() require a checkpoint, and pushHostRequirementReminders() appends the “Before your final answer” system message. Finishing here immediately after a successful return-direct tool gives the model no opportunity to satisfy that requirement; conversation runs then persist and replay this stale reminder on the next user turn. Suppress the reminder for terminal completion or explicitly resolve the checkpoint policy before returning.
Useful? React with 👍 / 👎.
|
Verification on head c21310d:
A local full integration run reported 460/461 because an ambient user-owned skill has a description over the 1024-character validation limit. The same integration suite passes in clean GitHub CI, confirming this is unrelated to the PR. No merge, release, or publish performed. |
Summary
Verification