Skip to content

Fix odao execute-upgrade bugs, add missing pDAO setting bindings - #1186

Merged
0xfornax merged 6 commits into
masterfrom
dao-command-bugfixes
Aug 24, 2026
Merged

Fix odao execute-upgrade bugs, add missing pDAO setting bindings#1186
0xfornax merged 6 commits into
masterfrom
dao-command-bugfixes

Conversation

@thomaspanf

Copy link
Copy Markdown
Member

This PR resolves a handful of small pdao/odao proposal related bugs:

  1. The CLI path for odao upgrade execute-upgrade was printing a hashed value for the proposal type instead of printing the human readable value.
  2. execute-upgrade was calling execute on the wrong contract
  3. We were missing bindings/cli commands for a handful of protocol settings:
- upgradeveto.quorum
- upgrade.delay
- network.reth.deposit.delay
- node.withdrawal.cooldown
- node.voting.power.stake.maximum

@github-actions

Copy link
Copy Markdown

Coverage Report

@0xfornax
0xfornax merged commit e9e60ca into master Aug 24, 2026
5 of 6 checks passed
@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/bindings/dao/upgrades 0.00% (ø)
github.com/rocket-pool/smartnode/bindings/settings/protocol 0.41% (-0.02%) 👎
github.com/rocket-pool/smartnode/rocketpool-cli/odao 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao 0.16% (-0.00%) 👎
github.com/rocket-pool/smartnode/rocketpool/api/pdao 0.08% (-0.00%) 👎
github.com/rocket-pool/smartnode/shared/types/api 4.59% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/bindings/dao/upgrades/details.go 0.00% (ø) 654 (+51) 0 654 (+51)
github.com/rocket-pool/smartnode/bindings/settings/protocol/network.go 0.00% (ø) 1922 (+74) 0 1922 (+74)
github.com/rocket-pool/smartnode/bindings/settings/protocol/node.go 0.00% (ø) 782 (+142) 0 782 (+142)
github.com/rocket-pool/smartnode/bindings/settings/protocol/security.go 0.00% (ø) 528 (+148) 0 528 (+148)
github.com/rocket-pool/smartnode/bindings/settings/protocol/setting-types.go 18.07% (ø) 166 30 136
github.com/rocket-pool/smartnode/rocketpool-cli/odao/execute-upgrade.go 0.00% (ø) 2076 (-96) 0 2076 (-96)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/commands.go 0.00% (ø) 12031 (+665) 0 12031 (+665)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/get-settings.go 0.00% (ø) 2451 (+115) 0 2451 (+115)
github.com/rocket-pool/smartnode/rocketpool-cli/pdao/propose-settings.go 0.00% (ø) 4059 (+220) 0 4059 (+220)
github.com/rocket-pool/smartnode/rocketpool/api/pdao/get-settings.go 0.00% (ø) 7357 (+470) 0 7357 (+470)
github.com/rocket-pool/smartnode/rocketpool/api/pdao/propose-settings.go 0.00% (ø) 21893 (+1312) 0 21893 (+1312)
github.com/rocket-pool/smartnode/shared/types/api/pdao.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants