Standardize CLI logger names - #109
Merged
Merged
Conversation
- In `fsdb_healthcheck.py`, set `ROMI_APP_LOGGER` using `__name__.split('.')[-1]` before creating the logger and instantiate `logger` with `os.getenv('ROMI_APP_LOGGER')`.
- Apply the same `ROMI_APP_LOGGER` naming change to `fsdb_import_folder.py`, `fsdb_import_images.py`, `fsdb_import_file.py`, and `shared_fsdb.py`.
- Ensure the environment variable is defined prior to logger creation for consistent logger names across all FSDB CLI commands.
- Set `ROMI_APP_LOGGER` using `__name__.split('.')[-1]` to capture the module’s basename.
- Ensure the logger is instantiated with the updated environment variable for consistent naming across FSDB CLI commands.
- Delete the `fsdb_healthcheck = "plantdb.comons.cli.fsdb_healthcheck:main"` line from `plantdb/src/server/pyproject.toml` to clean up unused script configuration.
ArthurLuciani2
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
fsdb_rest_api_sync.py,fsdb_healthcheck.py,fsdb_import_folder.py,fsdb_import_images.py,fsdb_import_file.py,shared_fsdb.py):ROMI_APP_LOGGERusing__name__.split('.')[-1]to capture the module’s basename.os.getenv('ROMI_APP_LOGGER')after the environment variable is set.Others
fsdb_healthcheckentry fromplantdb/src/server/pyproject.tomlas this is a CLI fromplantdb.commons.