chore: drop devenv, take the toolchain from the host - #87
Merged
Merged
Conversation
rubas/dev is retired. The Taskfile now sets EXMPEG_BUILD=1, and AGENTS.md names the host packages a source build needs, the same way our other NIF libraries do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rubas/dev is retired, so
devenv.nixcan no longer import its modules.devenv.nix,devenv.lock, and the devenv lines in.gitignore.EXMPEG_BUILD=1, sotask compilestill builds the NIF from source.This follows
whisper_cppandwhisper_ct2, which take their native toolchain from the host and document it. CI already installs everything itself through.github/actions/setupand never used devenv.Check: in a fresh worktree with
EXMPEG_BUILD,LIBCLANG_PATH, andBINDGEN_EXTRA_CLANG_ARGSunset,task setup && task check && task test:integrationpasses on Arch (FFmpeg 9.0.1, clang 22). The NIF compiled from source and the integration suite ran 104 tests with 0 failures.