ci: run the checks on bot PRs - #49
Merged
Merged
Conversation
The gate compared the PR author with the repo owner, so PRs that the agents open as rubas-agent[bot] skipped the Rust checks. A same-repo check keeps fork PRs off the incus runners just the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Checksjob inci.ymlran only when the PR author was the repo owner. PRs that the agents open asrubas-agent[bot]skipped it, so they could merge without the Rust checks. #45, #47, and #48 all showChecksas skipped.The new gate is
github.event.pull_request.head.repo.full_name == github.repository. A fork PR still never reaches the incus runners, because only a branch of this repo passes. A bot PR now runs the full checks. The AGENTS.md line that describes the gate says the same now.This PR is itself a bot PR, so its
Checksrun is the test.