install: drop install.sh and the Nix flake, install with mise - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
The README offers three install paths:
install.sh,cargo install, and the Nix flake with a Home Manager module.curl -fsSL https://github.com/rubas/kagi/releases/latest/download/install.sh | sh nix profile install github:rubas/kagiEach release ships the installer next to the archives (
gh release view v0.6.1 --json assets):Problem
Our machines now install the CLIs with mise,
"github:rubas/kagi" = "latest". mise downloads the release archive and checks its GitHub attestation. Nothing of ours usesinstall.shor the flake, but we still maintain them: a release job, a smoke test, a shellcheck step, a Nix build task, and rules inAGENTS.md.After
The README install section:
mise use -g github:rubas/kagi cargo install --git https://github.com/rubas/kagi # without miseA release ships only the two archives, with the same names, layout, and attestation. mise installs them as before (
mise install github:rubas/kagi@v0.6.1in a scratch data dir):The diff removes 505 lines and adds 22. No version bump: the binaries do not change, so no release runs.
Details
install.sh,flake.nix,flake.lock.release.yml: removed theinstallerjob, the install.sh smoke test, the install.sh upload, and theattestations: readpermission that only the smoke test used. The build job, the archive attestation, and both archive uploads are unchanged.ci.yml: removedshellcheck install.sh. There was no Nix CI job.Taskfile.yml: removedinstallandtest:nix, andtest:nixfromci..github/release-notes.md: the install line is nowmise use -g github:rubas/kagi@<tag>. mise accepts thevtag.AGENTS.md: removed the installer and flake rules and the Nix gate. Added one rule: mise picks the archive by the OS and architecture in its name and finds the binaries inbin/, so a rename or a new layout breaks every machine.task lint(clippy, zizmor: no findings),task test,dprint check,cargo fmt --checkpass.actionlintshows only findings that exist onmain(theincusrunner label, SC2129 in the unchanged prepare step).kagi-installscript still downloadsinstall.shfrom the latest release. v0.6.1 keeps it, so nothing breaks now, but the mise switch in the dotfiles must reachmainbefore the next kagi release.