Stop the report tab row from becoming scrollable - #461
Merged
Merged
Conversation
The tab links carried `-mb-px` so the active underline sits on top of the row's bottom border. Because the links live inside the `overflow-x-auto` container, that negative margin made the content 1px taller than the container's content box, so the tab row rendered a scrollbar even when the tabs fit comfortably. Move the negative margin to a new inner scroll wrapper and keep the border and padding on the outer element. The active underline still overlaps the border, nothing overflows vertically, and the row can still scroll horizontally on narrow phones (now without a visible scrollbar, matching the sidenav). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…llbar Picks up the system-test fix from #458 so CI runs against current main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
/reportsthe row holding the tabs (Tasks, Team members, …) rendered a scrollbar even though the tabs fit, which looked out of place.Cause
The tab links carry
-mb-pxso the active underline sits on top of the row's bottom border. Since the links live inside theoverflow-x-autocontainer, that negative margin makes the content 1px taller than the container's content box (measuredclientHeight45 vsscrollHeight46).overflow-x: autoalso turnsoverflow-yintoauto, so the 1px of vertical overflow was enough to produce a scrollbar.Fix
Move the negative margin to a new inner scroll wrapper and keep the border and padding on the outer element:
no-scrollbar, matching the pattern already used in_sidenav.html.erb.Testing
Verified the geometry in a browser on an isolated copy of the same markup and CSS:
clientHeight/scrollHeightare now 46/46 andclientWidth/offsetWidth600/600, i.e. no overflow and no scrollbar gutter. The change is markup-only and touches one partial.🤖 Generated with Claude Code