Add detail and status to custom metric rows#37
Open
noponoponopo wants to merge 1 commit into
Open
Conversation
Signed-off-by: nopo <dev@nopo1.com>
Collaborator
|
@noponoponopo If there are any changes that significantly affect the visual appearance, please make sure to include appropriate screenshots to showcase them. Additionally, I intend to handle the custom metrics JSON schema with extreme caution, as any changes once made will have a significant impact. Please be prepared for the fact that requests will not be approved easily. This also applies to the other pull requests you have created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Contribution
Summary of the Proposal
This pull request adds two optional fields to each Custom Metrics row:
detaildisplays secondary text below the row.statedisplays a colored status indicator usingactive,waiting,completed, orerror.The fields are optional, so existing Custom Metrics JSON files preserve their current behavior.
A dedicated
CustomMetricViewkeeps the row presentation separate from the card presentation.All 136 tests pass.
Reason for the new feature
Custom Metrics producers currently need to combine status, value, and supporting context into a single display string.
The optional fields provide a structured way to show concise status information and secondary context. This is useful for sessions, jobs, queues, services, and other metrics where a value alone does not provide enough information.
The maintenance cost is limited to two optional Codable fields, one status enum, and a dedicated row view. Existing JSON files do not require migration.
Checklist