Allow reordering custom metrics sources#55
Open
noponoponopo wants to merge 11 commits into
Open
Conversation
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Signed-off-by: nopo <dev@nopo1.com>
Collaborator
|
@noponoponopo As for the code, while the general implementation approach is correct, there are quite a few parts I would like to revise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Contribution
Summary of the Proposal
Allow users to reorder custom metrics sources by dragging the handle in Metrics settings.
The new order is persisted in the existing custom metrics configuration and immediately applied to custom metrics displays.
Reason for the new feature
Users with multiple custom metrics sources currently need to remove and re-add sources to change their display order.
This change uses the existing source array as the display order, adds no new settings or dependencies, and follows the drag-and-drop pattern already used by the custom runner frame editor.
Verification
Checklist
screen.2026-07-18.17.04.38.mov