fix: preserve empty dict handler output#535
Open
chenlichao wants to merge 1 commit into
Open
Conversation
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
Promptless prepared a documentation update related to this change. Triggered by runpod-python PR #535 Added a "Handler return values" section to the Serverless handler functions docs, explaining how a handler's return value maps to the job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output: {}.Why this helps
KeyErrorexception within framework #459: handlers that intentionally return{}should complete successfully instead of causing local FastAPI simulation to raiseKeyError: 'output'.Test Plan
pytest tests/test_serverless/test_modules/test_fastapi.py -q --no-cov(8 passed)Note: a targeted run without
--no-covalso had all 8 tests pass, but failed the repository-wide coverage threshold because only one test file was selected.