fix(git): Apply pr hint to git-fetch-with-cli - #17437
Merged
Merged
Conversation
rustbot
added
A-git
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 3, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 5, 2026
Update cargo submodule 9 commits in b2e9d5f9db3fb1c454ab84f10c16508984a266e2..3c0b534756e166d12eb9fd2e1abfe5b42ac6101e 2026-09-02 14:49:16 +0000 to 2026-09-04 17:03:10 +0000 - fix(trim-paths)!: limit options to `none|object|all` (rust-lang/cargo#17432) - fix(git): Apply pr hint to git-fetch-with-cli (rust-lang/cargo#17437) - fix(git): Make PR dep note cloer to our style guide (rust-lang/cargo#17436) - docs: clarify cargo vendor source config option (rust-lang/cargo#17435) - docs(trim-paths): workspace remap begins with `.` (rust-lang/cargo#17433) - docs: Switch from "target triple" to "target tuple" (rust-lang/cargo#17430) - docs(trim-paths): add limitations and polish (rust-lang/cargo#17425) - fix(git): Simplify error message (rust-lang/cargo#17429) - chore(deps): update rust crate base64 to 0.23.0 (rust-lang/cargo#17418)
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 5, 2026
Update cargo submodule 9 commits in b2e9d5f9db3fb1c454ab84f10c16508984a266e2..3c0b534756e166d12eb9fd2e1abfe5b42ac6101e 2026-09-02 14:49:16 +0000 to 2026-09-04 17:03:10 +0000 - fix(trim-paths)!: limit options to `none|object|all` (rust-lang/cargo#17432) - fix(git): Apply pr hint to git-fetch-with-cli (rust-lang/cargo#17437) - fix(git): Make PR dep note cloer to our style guide (rust-lang/cargo#17436) - docs: clarify cargo vendor source config option (rust-lang/cargo#17435) - docs(trim-paths): workspace remap begins with `.` (rust-lang/cargo#17433) - docs: Switch from "target triple" to "target tuple" (rust-lang/cargo#17430) - docs(trim-paths): add limitations and polish (rust-lang/cargo#17425) - fix(git): Simplify error message (rust-lang/cargo#17429) - chore(deps): update rust crate base64 to 0.23.0 (rust-lang/cargo#17418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
It was added for libgit2 but not git-cli
How to test and review this PR?
I tested this by forcing git-cli for the relevant tests and they still passed.
I did not add any tests for this because we will get coverage with #17329. I avoided duplicating the tests for each git backend out of concern for getting more rate limits from github in CI.