Skip to content

OpenBSD: add getexecpath() - #5465

Open
brad0 wants to merge 1 commit into
rust-lang:mainfrom
brad0:getexecpath_openbsd
Open

OpenBSD: add getexecpath()#5465
brad0 wants to merge 1 commit into
rust-lang:mainfrom
brad0:getexecpath_openbsd

Conversation

@brad0

@brad0 brad0 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

add getexecpath() support for OpenBSD.

Sources

https://github.com/openbsd/src/blob/6f5c51ae477e3fbcceb5c62bf24ab89dede0d1c6/include/unistd.h

@rustbot label +stable-nominated

@rustbot

rustbot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in an OpenBSD module

cc @semarie

Some changes occurred in a NetBSD-like module

cc @semarie

@brad0
brad0 marked this pull request as draft September 4, 2026 07:13
@brad0
brad0 force-pushed the getexecpath_openbsd branch 3 times, most recently from 3cd2f16 to 844e3a0 Compare September 4, 2026 07:21
@brad0
brad0 force-pushed the getexecpath_openbsd branch from 844e3a0 to cbc4591 Compare September 4, 2026 07:22
@brad0
brad0 marked this pull request as ready for review September 4, 2026 07:38

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot

rustbot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 4, 2026
@brad0

brad0 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@tgross35

tgross35 commented Sep 4, 2026

Copy link
Copy Markdown
Member

Implementation looks fine to me but this seems brand new openbsd/src@6f5c51a so up to Sebastien whether to merge now or wait.

@brad0

brad0 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Implementation looks fine to me but this seems brand new openbsd/src@6f5c51a so up to Sebastien whether to merge now or wait.

Sure, I can wait either way.

@semarie

semarie commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

I would prefer if we wait a bit, at least that base userland to active using it.
But it should be short time.

@tgross35

tgross35 commented Sep 4, 2026

Copy link
Copy Markdown
Member

One month perhaps?

@rustbot blocked
@SnoozeThis wait 1 month -> remove label S-blocked, add label S-waiting-on-review

@SnoozeThis

Copy link
Copy Markdown

(https://snoozeth.is/UPFZvnLl_oQ) I will wait until Sun, 04 Oct 2026 18:56:08 UTC and then add label S-waiting-on-review and remove label S-blocked.

@rustbot claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-bsd O-unix S-blocked stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants