Skip to content

remove stale/duplicate tests - #162215

Open
malezjaa wants to merge 1 commit into
rust-lang:mainfrom
malezjaa:remove-stale-tests
Open

remove stale/duplicate tests#162215
malezjaa wants to merge 1 commit into
rust-lang:mainfrom
malezjaa:remove-stale-tests

Conversation

@malezjaa

@malezjaa malezjaa commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Conversation from: https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Duplicate.20tests/with/621165039

  • recursion2.rs -> recursion1.rs
  • drop-track-field-assign-nonsend.rs -> field-assign-nonsend.rs
  • drop-track-field-assign.rs -> field-assign.rs
  • suggest-local-var-for-vector.rs -> suggest-storing-local-var-for-vector.rs
  • recursion-issue-105275.rs -> recursion-issue-105937.rs
  • migrate-fail.rs -> nll-fail.rs
  • migrate-pass.rs -> nll-pass.rs
  • issue-29914-2.rs -> issue-29914.rs
  • drop-tracking-parent-expression.rs -> parent-expression.rs
  • tuple-like-structs-cross-crate-7899.rs -> tuple-struct-cross-crate-7899.rs
  • E0508-fail.rs -> E0508.rs
  • ex3-both-anon-regions-one-is-struct-4.rs -> ex3-both-anon-regions-one-is-struct-3.rs
  • stability_cfg2.rs -> stability-cfg2.rs
  • issue-1802-2.rs -> issue-1802-1.rs
  • tool_lints_2018_preview.rs -> tool_lints-rpass.rs
  • issue-58951-2.rs -> issue-58951.rs
  • issue-74761-2.rs -> issue-74761.rs
  • issue-30276-feature-flagged.rs -> issue-30276.rs

@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

r? @khyperia

rustbot has assigned @khyperia.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 21 candidates

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 2, 2026
@chenyukang

Copy link
Copy Markdown
Member

seems great.

nit:
should we keep the test file name in order? for example remove tests/rustdoc-html/recursion2.rs and now there are tests/rustdoc-html/recursion1.rs and tests/rustdoc-html/recursion3.rs. do we need to rename the last one.

there are several tests in this scenario.

@khyperia

khyperia commented Sep 3, 2026

Copy link
Copy Markdown
Member

could you please indicate here which test each of the deleted tests is duplicated by? thanks!

@malezjaa

malezjaa commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the file numbering and updated the pr body to have the test mapping.

@rust-bors

This comment has been minimized.

@rustbot

rustbot commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@chenyukang

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f63cf21 has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 6, 2026
…nyukang

remove stale/duplicate tests

Conversation from: https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Duplicate.20tests/with/621165039

* `recursion2.rs` -> `recursion1.rs`
* `drop-track-field-assign-nonsend.rs` -> `field-assign-nonsend.rs`
* `drop-track-field-assign.rs` -> `field-assign.rs`
* `suggest-local-var-for-vector.rs` -> `suggest-storing-local-var-for-vector.rs`
* `recursion-issue-105275.rs` -> `recursion-issue-105937.rs`
* `migrate-fail.rs` -> `nll-fail.rs`
* `migrate-pass.rs` -> `nll-pass.rs`
* `issue-29914-2.rs` -> `issue-29914.rs`
* `drop-tracking-parent-expression.rs` -> `parent-expression.rs`
* `tuple-like-structs-cross-crate-7899.rs` -> `tuple-struct-cross-crate-7899.rs`
* `E0508-fail.rs` -> `E0508.rs`
* `ex3-both-anon-regions-one-is-struct-4.rs` -> `ex3-both-anon-regions-one-is-struct-3.rs`
* `stability_cfg2.rs` -> `stability-cfg2.rs`
* `issue-1802-2.rs` -> `issue-1802-1.rs`
* `tool_lints_2018_preview.rs` -> `tool_lints-rpass.rs`
* `issue-58951-2.rs` -> `issue-58951.rs`
* `issue-74761-2.rs` -> `issue-74761.rs`
* `issue-30276-feature-flagged.rs` -> `issue-30276.rs`
rust-bors Bot pushed a commit that referenced this pull request Sep 6, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #159541 (Use query for Variant InhabitedPredicate)
 - #162364 (Use `#[repr(C)]` on debuginfo test structs)
 - #162215 (remove stale/duplicate tests)
 - #162335 (Add several new LLDB feature flags)
 - #162341 (add regression test for packus_epi16 issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants