Added org github tokens to check untracked private repositories - #2666
Added org github tokens to check untracked private repositories#2666cuba0001 wants to merge 1 commit into
Conversation
Dry-run check results |
| "GITHUB_TOKEN_{}", | ||
| org.to_ascii_uppercase().replace('-', "_") | ||
| ) | ||
| } |
There was a problem hiding this comment.
We already parse and select GITHUB_TOKEN_{ORG} credentials in
team/src/sync/github/api/tokens.rs
Line 194 in 0a7e85b
Could we reuse that mechanism here?
There was a problem hiding this comment.
It was a bit tricky because of two github clients. I needed to expose tokens.rs to reuse it in api/github.
03dec8b to
5626f10
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Sorry I didn't have time to look into this. I'm unassigning this from me because I'm going to rustconf and after that I'll be on PTO for two weeks. |
Related #2654