Skip to content

fix: Fix exported_private_dependencies - #338

Open
mkroening wants to merge 1 commit into
rust-osdev:mainfrom
mkroening:exported_private_dependencies
Open

fix: Fix exported_private_dependencies#338
mkroening wants to merge 1 commit into
rust-osdev:mainfrom
mkroening:exported_private_dependencies

Conversation

@mkroening

Copy link
Copy Markdown
Member
$ cargo check -Zpublic-dependency
warning: crate `smallvec` from private dependency 'smallvec' is re-exported
 --> src/aml/resource.rs:7:9
  |
7 | pub use smallvec;
  |         ^^^^^^^^
  |
  = note: `#[warn(exported_private_dependencies)]` on by default
note: dependency `smallvec` declared here
  --> Cargo.toml:24:1
   |
24 | smallvec = { version = "1.15.2", default-features = false }
   | --------

warning: type `RawSpinlock` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:106:5
    |
106 |     pub namespace: Spinlock<Namespace>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `Spin` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:106:5
    |
106 |     pub namespace: Spinlock<Namespace>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `RawSpinlock` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:107:5
    |
107 |     pub object_token: Spinlock<ObjectToken>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `Spin` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:107:5
    |
107 |     pub object_token: Spinlock<ObjectToken>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `SmallVec<[u32; 1]>` from private dependency 'smallvec' in public interface
   --> src/aml/resource.rs:343:1
    |
343 | pub type Irqs = smallvec::SmallVec<[u32; 1]>;
    | ^^^^^^^^^^^^^
note: dependency `smallvec` declared here
  --> Cargo.toml:24:1
   |
24 | smallvec = { version = "1.15.2", default-features = false }
   | --------

warning: type `SmallVec<[u32; 1]>` from private dependency 'smallvec' in public interface
   --> src/aml/resource.rs:352:5
    |
352 |     pub irqs: Irqs,
    |     ^^^^^^^^^^^^^^
note: dependency `smallvec` declared here
  --> Cargo.toml:24:1
   |
24 | smallvec = { version = "1.15.2", default-features = false }
   | --------

Note that the following warnings remain:

warning: type `Mutex<RawSpinlock, Namespace>` from private dependency 'lock_api' in public interface
   --> src/aml/mod.rs:106:5
    |
106 |     pub namespace: Spinlock<Namespace>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(exported_private_dependencies)]` on by default

warning: type `Mutex<RawSpinlock, ObjectToken>` from private dependency 'lock_api' in public interface
   --> src/aml/mod.rs:107:5
    |
107 |     pub object_token: Spinlock<ObjectToken>,
    |     ^^^^^^^^^^

```
$ cargo check -Zpublic-dependency
warning: crate `smallvec` from private dependency 'smallvec' is re-exported
 --> src/aml/resource.rs:7:9
  |
7 | pub use smallvec;
  |         ^^^^^^^^
  |
  = note: `#[warn(exported_private_dependencies)]` on by default
note: dependency `smallvec` declared here
  --> Cargo.toml:24:1
   |
24 | smallvec = { version = "1.15.2", default-features = false }
   | --------

warning: type `RawSpinlock` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:106:5
    |
106 |     pub namespace: Spinlock<Namespace>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `Spin` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:106:5
    |
106 |     pub namespace: Spinlock<Namespace>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `RawSpinlock` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:107:5
    |
107 |     pub object_token: Spinlock<ObjectToken>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `Spin` from private dependency 'spinning_top' in public interface
   --> src/aml/mod.rs:107:5
    |
107 |     pub object_token: Spinlock<ObjectToken>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: dependency `spinning_top` declared here
  --> Cargo.toml:21:1
   |
21 | spinning_top = "0.3.0"
   | ------------

warning: type `SmallVec<[u32; 1]>` from private dependency 'smallvec' in public interface
   --> src/aml/resource.rs:343:1
    |
343 | pub type Irqs = smallvec::SmallVec<[u32; 1]>;
    | ^^^^^^^^^^^^^
note: dependency `smallvec` declared here
  --> Cargo.toml:24:1
   |
24 | smallvec = { version = "1.15.2", default-features = false }
   | --------

warning: type `SmallVec<[u32; 1]>` from private dependency 'smallvec' in public interface
   --> src/aml/resource.rs:352:5
    |
352 |     pub irqs: Irqs,
    |     ^^^^^^^^^^^^^^
note: dependency `smallvec` declared here
  --> Cargo.toml:24:1
   |
24 | smallvec = { version = "1.15.2", default-features = false }
   | --------
```

Note that the following warnings remain:

```
warning: type `Mutex<RawSpinlock, Namespace>` from private dependency 'lock_api' in public interface
   --> src/aml/mod.rs:106:5
    |
106 |     pub namespace: Spinlock<Namespace>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(exported_private_dependencies)]` on by default

warning: type `Mutex<RawSpinlock, ObjectToken>` from private dependency 'lock_api' in public interface
   --> src/aml/mod.rs:107:5
    |
107 |     pub object_token: Spinlock<ObjectToken>,
    |     ^^^^^^^^^^
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant