fix: Fix compilation with only the alloc feature - #342
Merged
Conversation
mkroening
commented
Sep 6, 2026
Member
```
$ cargo check --no-default-features --features alloc
error[E0433]: cannot find module or crate `aml` in this scope
--> src/lib.rs:314:9
|
314 | Aml(aml::AmlError),
| ^^^ use of unresolved module or unlinked crate `aml`
|
note: found an item that was configured out
--> src/lib.rs:57:9
|
56 | #[cfg(feature = "aml")]
| --------------- the item is gated behind the `aml` feature
57 | pub mod aml;
| ^^^
help: to make use of source file src/aml/mod.rs, use `mod aml` in this file to declare the module
|
48 + mod aml;
|
```
Contributor
|
Thanks @mkroening - I’m surprised & disappointed (and apologise to you) that the pipeline didn’t catch this, so I’ll take a look at that in more detail tomorrow. Your edit looks fine so if Isaac doesn’t get there first I’ll test it and merge tomorrow. |
Member
|
Yes - I also had a look because I thought we tested this... and we seem to? I'm not sure what is going on with the Action there. Thanks very much to both of you, Martin and Martin. I'm not at a computer I can test this myself at but this looks fine to me. |
Contributor
|
Tests OK so will merge. Thanks again @mkroening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.