uefi: bump from 0.20 to 0.38

[phip1611]

Bump the outdated uefi code to a much newer uefi version + misc code improvements

[phip1611]

what do we do about the semver CI issue?

[phil-opp]

The semver CI job fails also on main. cargo-semver-checks is usually not updated directly when the metadata format changes, so we have to wait a bit until it is supported. Safe to ignore for now

[Freax13]

Thanks, this is great work!

Sorry for the delay.

[Freax13]

This is subtly changing the behavior isn't it? Previously, we opened the BaseCode handle that was used to load the base image, but now we're looking at all BaseCode handles, right? If a system has more than one network interface (e.g. a wireless one and a wired one), this could change which interface is used to load the files, right?

[phip1611]

oh, that was a wonderful catch! I didn't thought about this. Fixed

[phip1611]

I've also conducted a "critical LLM review" to check behavioral changes - seems to be in good shape now!

[Freax13]

I've also conducted a "critical LLM review" to check behavioral changes - seems to be in good shape now!

how'd you do that?

[phip1611]

The CI failures seem to be unrealated @Freax13 - probably caused by the new clippy beta/nightly update.

PSA: I'll be on vacation for the rest of the month

[phil-opp]

I don't think that the CI failures are spurious. I found this in the logs of the failed Check job:

[lock_api 0.4.10] error[E0463]: can't find crate for `std`
  [lock_api 0.4.10]   |
  [lock_api 0.4.10]   = note: the `x86_64-unknown-uefi` target may not be installed
  [lock_api 0.4.10]   = help: consider downloading the target with `rustup target add x86_64-unknown-uefi`
  [lock_api 0.4.10]   = help: consider building the standard library from source with `cargo build -Zbuild-std`
  [lock_api 0.4.10] 
  [lock_api 0.4.10] error: aborting due to 1 previous error
  [lock_api 0.4.10] 
  [lock_api 0.4.10] For more information about this error, try `rustc --explain E0463`.
  [lock_api 0.4.10] error[E0463]: can't find crate for `core`
  [lock_api 0.4.10]   |
  [lock_api 0.4.10]   = note: the `x86_64-unknown-uefi` target may not be installed
  [lock_api 0.4.10]   = help: consider downloading the target with `rustup target add x86_64-unknown-uefi`
  [lock_api 0.4.10]   = help: consider building the standard library from source with `cargo build -Zbuild-std`
  [lock_api 0.4.10] 
  [lock_api 0.4.10] error: aborting due to 1 previous error
  [lock_api 0.4.10] 
  [lock_api 0.4.10] For more information about this error, try `rustc --explain E0463`.
  [lock_api 0.4.10] warning: autocfg could not probe for `std`

So something is trying to bring in a std dependency, which doesn't work for this bare-metal project.

I'll look into it, have a good vacation @phip1611!

edit: Ah, that's just a autocfg thing, not an actual error.

[phil-opp]

Ok, the actual error is:

error: error loading target specification: rustc-abi: invalid rustc abi: 'x86-softfloat'. allowed values: 'x86-sse2', 'powerpc-spe', 'softfloat' at line 23 column 1

This is fixed by #569 , so a merge/rebase should be enough to fix it.