win32: reset MARKER_ACTIVATE properly

winit-win32/src/window.rs

@@ -1657,6 +1657,7 @@ unsafe fn init(
     let menu = win_attributes.menu;
     let fullscreen = attributes.fullscreen.clone();
     let maximized = attributes.maximized;
+    let active = attributes.active;
     let mut initdata = InitData { runner, attributes, win_attributes, window_flags, window: None };
 
     let (style, ex_style) = window_flags.to_window_styles();
@@ -1700,6 +1701,11 @@ unsafe fn init(
         win.set_maximized(true);
     }
 
+    if !active {
+        win.window_state_lock()
+            .set_window_flags_in_place(|f| f.insert(WindowFlags::MARKER_ACTIVATE));
+    }
+
     Ok(win)
 }
 

winit-win32/src/window_state.rs

@@ -380,19 +380,18 @@ impl WindowFlags {
     }
 
     /// Adjust the window client rectangle to the return value, if present.
-    fn apply_diff(mut self, window: HWND, mut new: WindowFlags) {
-        self = self.mask();
-        new = new.mask();
+    fn apply_diff(self, window: HWND, new: WindowFlags) {
+        let old = self.mask();
+        let new = new.mask();
 
-        let mut diff = self ^ new;
+        let mut diff = old ^ new;
 
         if diff == WindowFlags::empty() {
             return;
         }
 
         if new.contains(WindowFlags::VISIBLE) {
-            let flag = if !self.contains(WindowFlags::MARKER_ACTIVATE) {
-                self.set(WindowFlags::MARKER_ACTIVATE, true);
+            let flag = if !old.contains(WindowFlags::MARKER_ACTIVATE) {
                 SW_SHOWNOACTIVATE
             } else {
                 SW_SHOW

winit/src/changelog/unreleased.md

@@ -51,3 +51,4 @@ changelog entry.
 - Removed the `url` dependency from `winit-core`, along with `SendData::from_file_paths`,
   `TypedData::try_as_file_paths` and `impl From<Vec<url::Url>> for SendData`. Use `SendData::Uris`
   / `TypedData::try_as_uris` with `file:` URIs instead.
+- On Windows, if the window is created through `with_active(false)`, subsequent `window.set_visible(true)` calls will now focus the window (the current behavior is the window only gets focus if you call `window.set_focus()` or `window.set_maximized(true)`) this is consistent with the other platforms.