ERL_NIF_TERM as newtype - #766
Merged
Merged
Conversation
filmor
marked this pull request as ready for review
September 16, 2026 22:29
filmor
force-pushed
the
term-newtype
branch
2 times, most recently
from
September 21, 2026 16:04
c7eb56b to
24bacb3
Compare
filmor
force-pushed
the
term-newtype
branch
from
September 21, 2026 16:06
24bacb3 to
5ba649f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the different calling conventions for "structs",
ERL_NIF_TERMwas not implemented as a type-safe wrapper. Nowadays, Rust has#[repr(transparent)]to deal with these cases, so we can wrap term objects properly. While at it, this drops a bunch of unnecessary type aliasing betweenrustler,rustler::wrapper, andrustler::sys.