RFC: Drop rustler::wrapper - #768
Conversation
Instead of using the intermediate half-safe function layer, we use the `enif_*` functions now directly in the high level functions.
ef997a9 to
5ae3238
Compare
…pointer (#86) ProgressEmitter and CancelGuard now borrow the calling NIF's Env<'a> instead of a raw NIF_ENV pointer. This removes the last use of rustler::wrapper, which rusterlium/rustler#768 deletes, and drops ffi_helpers::reconstruct_env, a safe function that returned an Env with an arbitrary lifetime. No behavior change. Co-authored-by: Dominic Rubas <1042243+rubas@users.noreply.github.com>
|
exmpeg used |
|
#456 made the usage of rustler::wrapper superfluous for |
|
Thanks for the heads up and for all your hard work! Made the appropriate changes in Explorer elixir-explorer/explorer#1164. When CI goes green I'll merge it in! |
Instead of using the intermediate half-safe function layer, we use the
enif_*functions now directly in the high level functions.From a cursory github search, this affects the following codebases:
Could you explain what you exactly drop down to
rustler::wrapperfunctions for? Can the same be achieved through direct usage ofrustler::sysor with a proper safe wrapper that simply doesn't exist yet?